Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reader_dispatch not yielding anything #68

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Fix reader_dispatch not yielding anything #68

merged 2 commits into from
Jan 14, 2022

Conversation

hofaflo
Copy link
Collaborator

@hofaflo hofaflo commented Jan 14, 2022

data_dir has to be passed as a keyword argument since #65 changed the order of arguments in the reader functions

fixes #67

@hofaflo hofaflo mentioned this pull request Jan 14, 2022
Closed
@cbrnr cbrnr merged commit dc901ca into cbrnr:main Jan 14, 2022
@cbrnr
Copy link
Owner

cbrnr commented Jan 14, 2022

Thanks @hofaflo! I think this warrants a hotfix release, could you push v4.0.1 please?

@hofaflo hofaflo deleted the fix-benchmark branch January 14, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reader_dispatch doesn't yield any reader
2 participants
@hofaflo @cbrnr