Kill_Procs test fails as killed process exits with error code

[Flamefire]

The GASPI command gaspi_proc_kill kills a remote process. However the return code of the killed process is unspecified. In GPI2 the remote process calls exit(-1) so an error code is set.

This results in a test failure when this error code is propagated.

Suggestion: As gaspi_proc_kill is a user request to terminate the process, it should not return an error code. So call exit(0) instead.

[mrahn]

I am confused:

• "kills a remote process" -> No, according to the spec: "sends an interrupt signal".
• "In GPI2" -> Are you talking about the test suite? Can you elaborate please?

[Flamefire]

The spec further says:

gaspi_proc_kill sends an interrupt signal to the Gaspi process incorporating the rank given by parameter rank . This can be used, for example, to realise(sic!) the registration of a user defined signal handler function which ensures the controlled shut down of an entire Gaspi application at the global level if the application receives an interrupt signal ( STRG + C ) in the interactive master process.
Every application should register such or a similar signal handler (c. f. listing 9).

In case of successful procedure completion, i. e. return value GASPI_SUCCESS , the remote
process has been terminated.

In this case I'm even escalating this as a bug in GPI2 that it does not adhere to the spec and simply calls exit(-1) instead of sending SIGINT:

GPI-2/src/GPI2_SN.c

Line 1502 in b927892

_exit(-1);

• "In GPI2": I mean

  GPI-2/src/GPI2_SN.c

  Line 1502 in b927892

  _exit(-1);

  
  The testsuite tests this function:

  GPI-2/tests/tests/init/kill_procs.c

  Line 22 in b927892

  ASSERT(gaspi_proc_kill( i, GASPI_BLOCK));

  
  Hence there will be a process with non-zero exitcode spawned by the testsuite which may or may not make the test-fail depending on whether the error-code is propagated to the spawner/gaspi_run