Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaspi_run does not properly quote file name arguments #71

Open
sloede opened this issue May 19, 2022 · 0 comments
Open

gaspi_run does not properly quote file name arguments #71

sloede opened this issue May 19, 2022 · 0 comments

Comments

@sloede
Copy link
Contributor

sloede commented May 19, 2022

Due to

if [ -r $1 ]; then

and many other places where input is used without quotation, it is not possible to provide command line arguments with non-standard characters in them. For example,

gaspi_run -m "machine file" $(which hostname)

will fail with something like

/home/mschlott/hackathon/GPI-2/GPI-2/bin/gaspi_run: 155: [: machine: unexpected operator

Error: Cannot read machine file (-m option) (or file does not exist)

I believe this can be avoided comparably easily by properly quoting all command line arguments, e.g.,

    if [ -r "$1" ]; then 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant