Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts still pass through to browser #13

Closed
ericanderson opened this issue Jul 6, 2012 · 3 comments
Closed

Keyboard shortcuts still pass through to browser #13

ericanderson opened this issue Jul 6, 2012 · 3 comments
Labels

Comments

@ericanderson
Copy link

Confirmed in Safari on Lion. You have an example that is cmd+shift+k. When I do this, the Safari menu flops between checked/unchecked for the "Block popup windows" item.

@ccampbell
Copy link
Owner

Yeah, the command k and command shift k are not the best examples cause thy do things on Firefox as well. I will probably replace them with something else.

@rodneyrehm
Copy link

Better add event.preventDefault() to the demo to show how default browser key-combos can be overwritten.

@ccampbell
Copy link
Owner

Updated to prevent default on demo page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants