Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts on mobile are broken #5

Closed
ccatterina opened this issue May 13, 2023 · 0 comments · Fixed by #8
Closed

Charts on mobile are broken #5

ccatterina opened this issue May 13, 2023 · 0 comments · Fixed by #8
Labels
bug Something isn't working

Comments

@ccatterina
Copy link
Owner

ccatterina commented May 13, 2023 •
edited
Loading

After the refactor, on mobile, the charts axes doesn't cover the entire canvas.
@ccatterina ccatterina added the bug Something isn't working label May 13, 2023
ccatterina added a commit that referenced this issue May 14, 2023
@ccatterina
feat: dinamically set canvas height as canvas width / 2
eb9ee09 
Setting canvas height dinamically fixes also the issue with mobile view.

Fixes #5
ccatterina added a commit that referenced this issue May 14, 2023
@ccatterina
feat: dinamically set canvas height as canvas width / 2
fb7faa0 
Setting canvas height dinamically fixes also the issue with mobile view.

Fixes #5
@ccatterina ccatterina mentioned this issue May 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: dinamically set canvas height as canvas width / 2 ccatterina/MathCanvas
1 participant
@ccatterina