Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts from outline #526

Closed
drewyoungren opened this issue Apr 21, 2023 · 3 comments
Closed

Artifacts from outline #526

drewyoungren opened this issue Apr 21, 2023 · 3 comments

Comments

@drewyoungren
Copy link
Collaborator

#522 has to be reverted. Look at the artifacts from intersections:

artifacts-outilnes

Here is one commit before (3d3a647):

artifacts-3d3a647

@nikolas
Copy link
Member

nikolas commented Apr 21, 2023

Oh weird - appears to be specific to Chrome, I'm not seeing this on Firefox in my testing.

@nikolas
Copy link
Member

nikolas commented Apr 21, 2023

I'm taking a look to see if I can resolve this without reverting.

@nikolas
Copy link
Member

nikolas commented Apr 21, 2023

I disabled the problematic part of the new rendering flow for now (adbf5e5)

It looks like Three.js's OutlinePass is doing some downsampling. Related issues with this noted here: https://stackoverflow.com/q/21050797/173630

I wasn't able to resolve these issues yet after messing with the resolution and downsampling config a bunch. So, we'll see if we can get this working and be more aware of maintaining the existing clean render going forward.

@nikolas nikolas closed this as completed Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants