Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Valetudo RE #9

Closed
mukhametshin opened this issue Mar 17, 2021 · 5 comments
Closed

Support for Valetudo RE #9

mukhametshin opened this issue Mar 17, 2021 · 5 comments

Comments

@mukhametshin
Copy link

It would be very kind if the Valetudo RE could be also supported one day.
Currently I got the following error after having Test Connection button pressed:

image

@ccoors
Copy link
Owner

ccoors commented Mar 17, 2021

Sorry, this is out of scope for this project. I would not even accept a ready-to-merge pull request. I do not want to encourage the usage of Valetudo RE in any way, shape or form. There will be no further discussion.

@ccoors ccoors closed this as completed Mar 17, 2021
@mukhametshin
Copy link
Author

@ccoors thank you for your response! No problem, sure, your project your rules ;)

@bruvv
Copy link

bruvv commented Apr 27, 2021

@ccoors may I ask what you reasons are for not encouraging the use of RE?

@ccoors
Copy link
Owner

ccoors commented Apr 27, 2021

Apart from my personal feelings for RE, which I won't go into (there has been enough talk about that on various channels), adding support for RE would require a lot of work since the old API works quite differently.

@tefracky
Copy link

tefracky commented Feb 1, 2022

Sorry, this is out of scope for this project. I would not even accept a ready-to-merge pull request. I do not want to encourage the usage of Valetudo RE in any way, shape or form. There will be no further discussion.

Apart from my personal feelings for RE, which I won't go into (there has been enough talk about that on various channels), adding support for RE would require a lot of work since the old API works quite differently.

This really sound like "I don't want, becaus I don't want." Well, thats bad, so the only hope is that someome will fork it.

Repository owner locked as too heated and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants