Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register multiple algortihms #85

Open
fcangialosi opened this issue May 19, 2021 · 0 comments
Open

register multiple algortihms #85

fcangialosi opened this issue May 19, 2021 · 0 comments

Comments

@fcangialosi
Copy link
Member

in the current model, a calling application creates an instance alg of some struct implementing CongAlg and then (indirectly) calls portus::run_inner(..., alg), and portus assumes all new connections from the datapath should use this alg.

this limits applications to using one ccp algorithm at a time.

rather than having a separate ccp process for each algorithm, it probably makes more sense for a single process to be able to handle connections using different algorithms.

i think the minimally invasive change to support this would be to:

  • modify run_inner to instead take a list of CongAlgs rather than just a single one
  • have libccp send the name of the algorithm it wants to use in the Create message (for backwards-compatibility we could also specify the index of a default alg so that even if libccp leaves the algorithm field blank as it currently does, portus can still do something reasonable)
  • look up the appropriate CongAlg in the list and call new_flow on that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant