Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use module_offset in multi-panel nexus #673

Open
phyy-nx opened this issue Nov 30, 2023 · 0 comments
Open

Use module_offset in multi-panel nexus #673

phyy-nx opened this issue Nov 30, 2023 · 0 comments

Comments

@phyy-nx
Copy link
Contributor

phyy-nx commented Nov 30, 2023

Hi, pointed out by @biochem-fan, module_offset is used in DetectorFactory for single panel detector but is not used for multi panel detectors (DetectorFactoryFromGroup).

module_offset is in some ways redundant with the offset attribute of the NXtransformations NeXus class, but we should check for it and add it if present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phyy-nx