Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Limit" option for get_history call as per Electrum Protocol 2.0 #180

Closed
kzKallisti opened this issue Jun 22, 2023 · 2 comments
Closed

"Limit" option for get_history call as per Electrum Protocol 2.0 #180

kzKallisti opened this issue Jun 22, 2023 · 2 comments
Labels
suggestion New features to think about

Comments

@kzKallisti
Copy link

No description provided.

@cculianu
Copy link
Owner

Reference: https://github.com/spesmilo/electrumx/pull/90/files#diff-ffa7e37c618564f8c58d9072b5ef234e6e9b2cdf1d71d16be7dc356146cb475fR327

I will probably initially do this as optional second and third args: from_height and to_height (see above link for description). Is that acceptable to you @kzKallisti ?

@cculianu cculianu added the suggestion New features to think about label Jun 28, 2023
cculianu added a commit that referenced this issue Jun 28, 2023
@cculianu
Implement "paging" for blockchain.*.get_history
f6543b9 
Closes issue #180.  Optional 2nd and 3rd args to blockchain.*.get_history
can be used to limit the size of the returned history by looking only
within a certain block height range.

Implementation follows the suggested API for Electrum protocol version 2.0
proposed protocol spec, see:

https://github.com/spesmilo/electrumx/pull/90/files#diff-ffa7e37c618564f8c58d9072b5ef234e6e9b2cdf1d71d16be7dc356146cb475fR327
@cculianu
Copy link
Owner

Ok, this has been implemented on master. To test, one must either wait for me to do a release or compile from master. Here are the API docs: https://electrum-cash-protocol.readthedocs.io/en/latest/protocol-methods.html#blockchain.scripthash.get_history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion New features to think about
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cculianu @kzKallisti