Ordislow 26.0rc2 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the "standard" txns are ones that filter-out ordinals. Setting -ordisrespector=0 turns off this specific standardness flag.
We if -ordislow=1 (default), we maintain a rolling bloom filter of 1 million txns (~12.6MB memory) to keep track of ordinal-containing mempool txns seen. If a block arrives that contains such a txn, even before we fully evaluate it, we suppress announcements of the block to peers. Also added logic to refuse to upload the block to any peers after the fact as well. Required a new concept in the script engine: a script "warning", which gets bubbled up to caller and is used to decide if a txn we have seen has ordinals or not.
cculianu
force-pushed
the
ordislow_26.0rc2
branch
from
4475864
to
ef80cb4
Compare
… IBD Fixes a theoretical corner-case where if we are IBDing and some peer asks us for the ord block and we have it at the tip, which is actively being added-to, there is no reason why we shouldn't forward the block along, since it clearly is not "new" since we are still building our tip. Not a huge deal either way but this `i` needed dotting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just here to make it easy to review both commits at once as a single PR.