Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cex.io: maker/taker fees, presition, limits added and nonce() fixed #364

Merged
merged 1 commit into from
Oct 20, 2017
Merged

cex.io: maker/taker fees, presition, limits added and nonce() fixed #364

merged 1 commit into from
Oct 20, 2017

Conversation

mkutny
Copy link
Contributor

@mkutny mkutny commented Oct 20, 2017

No description provided.

@mkutny
Copy link
Contributor Author

mkutny commented Oct 20, 2017

I've hit the wall, really don't know how to fix this transpilation error.

@xpl
Copy link
Contributor

xpl commented Oct 20, 2017

I'm not sure if we have support for the Math.log10 in the transpiler. I think an advice from @kroitor is needed here :)

@xpl xpl requested a review from kroitor October 20, 2017 19:50
@kroitor kroitor self-assigned this Oct 20, 2017
@kroitor
Copy link
Member

kroitor commented Oct 20, 2017

Hi! Thanks for this submission, @mkutny ! I'll take a look into it and will add missing rules the transpiler for it to pass. Will be there very soon!

kroitor added a commit that referenced this pull request Oct 20, 2017
@kroitor
added Math.log* support to transpiler, #362, #364
a2969c7
kroitor
kroitor reviewed Oct 20, 2017
View reviewed changes
Copy link
Member

@kroitor kroitor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Math.log10 (just added it to the transpiler, it is uniform in most of the languages), everything seems correct, so I'm merging this! Thx!

@kroitor kroitor merged commit 8c7a166 into ccxt:master Oct 20, 2017
kroitor added a commit that referenced this pull request Oct 20, 2017
@kroitor
minor edit for php to survive #364
fbbed63
@mkutny mkutny deleted the cexio branch October 23, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroitor kroitor kroitor left review comments

Assignees

@kroitor kroitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkutny @xpl @kroitor