fix(coinbase) - add usePrivate option #22579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'll add static tests |
carlosmiei
reviewed
May 22, 2024
|
i decided to refrain from adding static tests, as they involve more changes (changes in test.ts too) to handle apiKey & secret fields, but i have pending 'tests reorg PR' so to avoid much conflicts, i'll wait that PR at first. |
carlosmiei
changed the title
kroitor
pushed a commit
that referenced
this pull request
May 27, 2024
* fix(coinbase) - priv api for public data 1 * added all other endpints * rename option --------- Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com> [ci skip]
|
Thank guys -I've pulled this version locally, installed it and tested the 'usePrivate' option. Looks good - am not getting those rate limit issues. |
|
@jtashiro Glad to hear that, let us know if anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #22571