Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socket tests for OSX #40

Closed
Max-Meldrum opened this issue Aug 23, 2019 · 3 comments
Closed

Fix socket tests for OSX #40

Max-Meldrum opened this issue Aug 23, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@Max-Meldrum
Copy link
Member

Opening too many files for OSX to handle....

@Max-Meldrum Max-Meldrum added bug Something isn't working Rust labels Aug 23, 2019
@Bathtor
Copy link
Contributor

Bathtor commented Aug 23, 2019

I feel it's probably more of a case of not closing things properly when you are done with them.
I checked on my system and the open fd limits is very low at 256, but still...running tests in sequence should not go over that, and yet it does on my system at least. So something's fishy there...

@Max-Meldrum
Copy link
Member Author

We might be setting the KompactConfig with a default NetworkConfig in some places where it is actually not needed. But still, the amount of sockets we utilise during the tests should still be under 15.

@Max-Meldrum
Copy link
Member Author

failing test fixed by #42

The number of fds should be reduced at least a bit when tests are refactored in #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants