Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global ID for events #100

Closed
xibz opened this issue Nov 25, 2022 · 6 comments
Closed

Add global ID for events #100

xibz opened this issue Nov 25, 2022 · 6 comments
Assignees
Labels
roadmap Items on the roadmap
Milestone

Comments

@xibz
Copy link
Contributor

xibz commented Nov 25, 2022

As discussed last week, a global ID is needed to ensure quick and efficient look ups for a series of events.

This new global ID would be a requirement for the links spec #10 as this would eliminate the need for links to backtrack to figure out how a series of events occurred, and instead, a simple query of the global ID would return all events associated with that global ID. Further this would give a logical grouping to the events that occurred for a particular job.

I propose the name span id and further I imagine the SDKs would need to change a little bit. I would imagine if no span ID is present, simply create one, and that would then be passed to all children events. I haven't spent too much time on thinking about this, but is that all that is needed to determine a span of events?

I'll spend some more time thinking about this, and see if I am able to get a proposal out.

@afrittoli
Copy link
Contributor

Thank you @xibz for bringing this up.

@e-backmark-ericsson
Copy link
Contributor

There is a "Distributed Tracing" extension to Cloudevents, that is intended to handle global IDs like the one requested here. If we promote that we will be more tightly coupled with and dependent on Cloudevents, which we might not want to be.

One idea could be that the CDEvents spec don't mention this at all, but that the SDKs (which build on Cloudevents SDKs?) could provide that.

https://github.com/cloudevents/spec/blob/main/cloudevents/extensions/distributed-tracing.md#distributed-tracing-extension

@afrittoli afrittoli added the roadmap Items on the roadmap label Dec 13, 2022
@afrittoli afrittoli added this to the v0.2 milestone Dec 19, 2022
@afrittoli afrittoli self-assigned this Dec 19, 2022
@afrittoli
Copy link
Contributor

#104

@afrittoli afrittoli modified the milestones: v0.2, v0.3 Mar 13, 2023
@afrittoli afrittoli modified the milestones: v0.3, v0.4 May 2, 2023
@afrittoli
Copy link
Contributor

Related PR: #139

@afrittoli
Copy link
Contributor

@xibz since #139 is merged now, can we close this issue?

@xibz
Copy link
Contributor Author

xibz commented Apr 2, 2024

closed via #139

@xibz xibz closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Items on the roadmap
Projects
Status: Done
Development

No branches or pull requests

3 participants