Patch/static analysis 2 #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now redundant variable.
|
I'll review it today or tomorrow. Sorry for the delay. |
egonw
requested changes
Jan 19, 2019
There was a problem hiding this comment.
Generally fine and thanks for the important work for code cleanup, some of it taking advantage of Java improvements since the changed code was written. A few points, of only one item I just disagree with, which is about testing consistency of atom type lists. That assert was added to ensure we fully test a particular atom type list and I see no reason why to remove that.
base/test-interfaces/src/test/java/org/openscience/cdk/interfaces/AbstractStrandTest.java
Show resolved
Hide resolved
base/test-core/src/test/java/org/openscience/cdk/atomtype/AbstractAtomTypeTest.java
Show resolved
Hide resolved
egonw
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly busy work, my IDE lights up light a Christmas tree for so much of the CDK it's easy to ignore the warnings.