Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/static analysis 2 #532

Merged
merged 21 commits into from Jan 23, 2019
Merged

Patch/static analysis 2 #532

merged 21 commits into from Jan 23, 2019

Commits on Jan 10, 2019

  1. Fix IntelliJ inspections, String init, unused monomer variable.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    0c5207b View commit details
    Browse the repository at this point in the history

  2. Fix redundant if, deprecated method call, and remove unused map field.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    b3087c4 View commit details
    Browse the repository at this point in the history

  3. Tidy imports.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    affc879 View commit details
    Browse the repository at this point in the history

  4. bondMap not needed, stereo in InChI is all atom based.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    3e8bced View commit details
    Browse the repository at this point in the history

  5. Cleanup HOST descriptors.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    29f3f83 View commit details
    Browse the repository at this point in the history

  6. Remove unsed sList array.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    2f3eee2 View commit details
    Browse the repository at this point in the history

  7. Params should be set on reaction type, clean up code.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    ed0759c View commit details
    Browse the repository at this point in the history

  8. Initial cleanup, this class had a lot of warnings.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    050f7db View commit details
    Browse the repository at this point in the history

  9. Remove unused ZORders

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    dfd6f28 View commit details
    Browse the repository at this point in the history

  10. Class cleanup

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    b407027 View commit details
    Browse the repository at this point in the history

  11. Remove unused variable.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    ee48add View commit details
    Browse the repository at this point in the history

  12. Capturing pseudo atom logic was previously wrong and removed, remove the 

    now redundant variable.
    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    cd1a7d9 View commit details
    Browse the repository at this point in the history

  13. getDescriptorNames() replicates the redundant code.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    2fd5929 View commit details
    Browse the repository at this point in the history

  14. Cleanup

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    8429a77 View commit details
    Browse the repository at this point in the history

  15. Add test and correct logic, trueBits needs to be set again.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    065380c View commit details
    Browse the repository at this point in the history

  16. Remove unused atomArom and clean up warnings/style.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    fd45bb3 View commit details
    Browse the repository at this point in the history

  17. bondsToHydrogens should be updated here.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    67c3c22 View commit details
    Browse the repository at this point in the history

  18. Default to warn level.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    2cd06ab View commit details
    Browse the repository at this point in the history

  19. Resolve assertion warnings.

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    0caedcd View commit details
    Browse the repository at this point in the history

  20. Old classic, remove Integer vs int

    @johnmay
    johnmay committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    07a3a96 View commit details
    Browse the repository at this point in the history

  21. Okay maybe a warning rather than a fail, @egonw can decide.

    @johnmay
    johnmay committed Jan 10, 2019
    1 Configuration menu
    Copy the full SHA
    4120c34 View commit details
    Browse the repository at this point in the history