Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly sort lambda runtime version #1296

Merged
merged 3 commits into from
May 12, 2023
Merged

fix: correctly sort lambda runtime version #1296

merged 3 commits into from
May 12, 2023

Conversation

clueleaf
Copy link
Contributor

Fixes #1271

Using this to sort versions.
https://stackoverflow.com/a/65687141

dontirun
dontirun approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@dontirun dontirun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🎉

@mergify mergify bot merged commit 14b7ad6 into cdklabs:main May 12, 2023
@clueleaf clueleaf deleted the fix/lambda_latest_version branch May 13, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontirun dontirun dontirun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Lambda runtime version numbers are sorted improperly when minor versions exceed 9
2 participants
@clueleaf @dontirun