Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: es6-promise #300

Closed
klausenbusk opened this issue Jul 4, 2020 · 4 comments · Fixed by #303
Closed

Update: es6-promise #300

klausenbusk opened this issue Jul 4, 2020 · 4 comments · Fixed by #303
Labels
📦 Update Request Request for an existing library on cdnjs to be updated

Comments

@klausenbusk
Copy link
Contributor

The dist directory was removed from the es6-promise git repository some time ago (stefanpenner/es6-promise#312).

The following versions is missing:

4.2.8
4.2.7
4.2.6
4.2.5
4.2.4
4.2.3
4.2.2
4.2.1
4.2.0

Relevant autoupdate "error":

2020/07/04 15:37:51 e/es6-promise.json: match **/* in /home/kristian/Hentet/cdnjs/git-cache/es6-promise/dist but doesn't exists
2020/07/04 15:37:51 e/es6-promise.json: no files matched

Library name: es6-promise

Library JSON file link: https://github.com/cdnjs/packages/blob/master/packages/e/es6-promise.json

Library source (NPM package or Git repo): Git at the moment, but we should switch to NPM

Files to include: The current configuration seems to be fine

I will open a PR if I don't forget.

@klausenbusk klausenbusk added the 📦 Update Request Request for an existing library on cdnjs to be updated label Jul 4, 2020
@klausenbusk
Copy link
Contributor Author

Relevant autoupdate "error":

We should probably make a list of "broken" packages and add a skip option, so we don't waste time on broken packages.

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 4, 2020

Adding a way to force packages to be skipped sounds like something that is just going to increase complexity in maintaining cdnjs, I'd much rather all packages are always considered.

@klausenbusk
Copy link
Contributor Author

Adding a way to force packages to be skipped sounds like something that is just going to increase complexity in maintaining cdnjs, I'd much rather all packages are always considered.

I partly agree, but it is hard to make autoupdate fast if we need to clone (too) many repositories just to discover that something is broken. Lets wait and see :)

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 4, 2020

If there are broken packages that are slowing the bot down, we should be fixing them or removing the auto-update config from them. Adding new logic just to skip isn't the right solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Update Request Request for an existing library on cdnjs to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants