(Some) packages aren't updating #341
Comments
|
will check this out in a few mins. Just let the bot on the loose, should start fixing those inconsistent latest versions ! |
|
Sorry, looks like "few mins" was more like "few weeks"!! For es6-promise, on disk we have all the versions, but they are not in the github repo. I see that the last publish on npm was a year ago... I think we need to have a closer look at the logic to determine the existing versions in |
|
Are the directories empty? I have seen that behavior before.
|
|
@klausenbusk yep empty, so git will not care about them 😢 |
|
I think the bot was fixed of this bug (it was trying to add versions when no files were matched). Maybe the local cdnjs/cdnjs clone just needs cleaning up (all empty directories being removed?) |
The code is broken. The code check if the directory exists, but don't delete it if |
|
I wouldn't say that broken really, empty directories should never exist and are the result of a previous bug? |
They are the result of a broken autoupdate config. We shouldn't create a directory if we have no files to copy. |
|
That was the previous bug that I believe was patched, unless I'm going mad -- we should no longer be creating directories if no files match |
I don't think it was. See PR: cdnjs/tools#139 |
|
With cdnjs/tools#139 merged, could you (@tc80) delete all the empty directories? ( |
|
Thanks for following up, yep! Will clean and comment here when done |
|
@klausenbusk ran After: Does this seem correct? Removed |
|
Ran After: Removed |
|
Autoupdate is redeployed and running. Reopen this if you see any strange behavior @klausenbusk . |
|
I haven't checked all the packages, but TypewriterJS and canvg hasn't updated (yet?)
|
|
Strange, will look into it. On disk there is just core.js |
|
Ah. |
|
@klausenbusk found the problem We are ignoring it. Will try to fix 👍 |
|
Same for |
|
@xtuc should we remove this check or should we decide on these packages on a per-package basis? |
|
Deployed change, and it just updated canvg, so I think we are good here 👍 @klausenbusk feel free to reopen this if you see anything strange! Thanks again for monitoring cdnjs so closely, you're awesome! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #302 I did open a few PRs:
Looking at the cdnjs repo, new versions has only been added for the
atmospherepackage. Why aren't the other packages updating? :)The text was updated successfully, but these errors were encountered: