Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update es6-promise w/ npm auto-update #303

Merged
merged 1 commit into from Jul 4, 2020
Merged

Update es6-promise w/ npm auto-update #303

merged 1 commit into from Jul 4, 2020

Conversation

klausenbusk
Copy link
Contributor

Resolves #300

@klausenbusk klausenbusk changed the title Update es6-promise w/ git auto-update Update es6-promise w/ npm auto-update Jul 4, 2020
@MattIPv4 MattIPv4 self-requested a review July 4, 2020 17:52
MattIPv4
MattIPv4 requested changes Jul 4, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the namespace field be dropped, please? We don't need it, so it might as well be removed whilst we're here.

@klausenbusk
Copy link
Contributor Author

Could the namespace field be dropped, please? We don't need it, so it might as well be removed whilst we're here.

Done. Do you want a "cleanup" PR?

$ grep -r '"namespace"' | wc
     52     153    2233

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 4, 2020

Nah, we can just drop them as they come up, they do no harm being there for now 👍

MattIPv4
MattIPv4 approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you

@MattIPv4 MattIPv4 merged commit 35fd67e into cdnjs:master Jul 4, 2020
@klausenbusk
Copy link
Contributor Author

How long should it take for the new versions to get added? Is something broken or is autoupdate just slow?

https://github.com/cdnjs/cdnjs/tree/master/ajax/libs/es6-promise
https://github.com/cdnjs/cdnjs/tree/master/ajax/libs/aframe (same issue, see PR: #304)

This was referenced Jul 8, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update: es6-promise
2 participants
@klausenbusk @MattIPv4