Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass rootMargin as String #5

Closed
danieljb opened this issue Mar 27, 2018 · 2 comments
Closed

Pass rootMargin as String #5

danieljb opened this issue Mar 27, 2018 · 2 comments

Comments

@danieljb
Copy link

When using IOlazy with IntersectionObserver Polyfill in Safari 11 the Polyfill’s _parseRootMargin method crashes with a TypeError e.split is not a function. (In 'e.split(/\s+/)', 'e.split' is undefined).
This is caused by IOlazy passing rootMargin as Array which can not work with the polyfill.

Please update IOlazy class to pass rootMargin as String which is – as far as I can tell – expected in the spec, too.

@cdowdy
Copy link
Owner

cdowdy commented Mar 28, 2018

thanks @danieljb I dunno why I overlooked that when I merged the PR.

I'll push a fix here in a bit!

@cdowdy cdowdy closed this as completed in e27f25f Mar 28, 2018
@danieljb
Copy link
Author

danieljb commented Apr 5, 2018

Thanks for the super fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants