This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Fix sail docker and upgrade code-server #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @deansheather |
deansheather
suggested changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: once this is merged I'll need to rebuild all of the sail images and push them to docker hub
@deansheather resolved feedback, should be ready |
deansheather
approved these changes
Mar 17, 2020
Thank you for your contributions. I'll push the changes to docker hub shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sail
using latestcode-server
which now supports ARM64 and X86 architecturesIt now appears to work
Open Issues
I needed to disable the installation of the docker vs-code extension as it can't be resolved using
code-server
for some reason, it looks like the namespace changed recently (https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker):