Refactor for Context only logging #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ammario
commented
Mar 31, 2020
•
ammario
commented
- Passing tests
- Pass ci
nhooyr
approved these changes
Mar 31, 2020
README.md
Outdated
| @@ -87,6 +87,8 @@ Here is a list of reasons how we improved on zap with slog. | |||
|
|
|||
| 1. Full [context.Context](https://blog.golang.org/context) support | |||
| - `slog` lets you set fields in a `context.Context` such that any log with the context prints those fields. | |||
| - `slog` stores the actual logger in the `context.Context`, following the example of the Go trace library. **Our | |||
There was a problem hiding this comment.
We should link to the open census trace godoc.
README.md
Outdated
| @@ -87,6 +87,8 @@ Here is a list of reasons how we improved on zap with slog. | |||
|
|
|||
| 1. Full [context.Context](https://blog.golang.org/context) support | |||
| - `slog` lets you set fields in a `context.Context` such that any log with the context prints those fields. | |||
| - `slog` stores the actual logger in the `context.Context`, following the example of the Go trace library. **Our | |||
| logger doesn't bloat type and function signatures.** | |||
There was a problem hiding this comment.
Don't think this needs to be bolded, it stands out too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.