Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Playlist TrackLists Do Not Show Skip & Settings Icons #37

Closed
cdrani opened this issue Jul 31, 2023 · 0 comments · Fixed by #39
Closed

[Bug]: Playlist TrackLists Do Not Show Skip & Settings Icons #37

cdrani opened this issue Jul 31, 2023 · 0 comments · Fixed by #39
Labels
bug Something isn't working

Comments

@cdrani
Copy link
Owner

cdrani commented Jul 31, 2023

Describe the bug

In playlist tracklist view, the skip and settings icons click events are not triggered

To Reproduce

Steps to reproduce the behaviour:

  1. Go to a Spotify Curated playlist such as "Discover Weekly"
  2. Click on on Skip or Settings Icon
  3. Settings icon click should cause Chorus Modal to display. Skip icon should set track as blocked and be highlight in Spotify green colour

Expected behaviour

Settings icon click should cause Chorus Modal to display. Skip icon should set track as blocked and be highlight in Spotify green colour

Screenshots

Screen.Recording.2023-07-31.at.00.03.11.mov

SOLUTION

Currently the Skip and Settings are set on the overall tracklist container based on the data-testid="track-list" as shown here:

const trackLists = Array.from(document.querySelectorAll('[data-testid="track-list"]'))

However, for the curated playlists, the data-testid is "playlist-tracklist".

image

We need to update the container query to include this other element as well. Per MDN:

Multiple selectors may be specified by separating them using commas.

const matches = myBox.querySelectorAll("div.note, div.alert")

however, to keep the line length manageable, preference would be to use an array instead and place the two selectors on separate lines.

Reach out if you need some help resolving this issue. 😄

@cdrani cdrani added the bug Something isn't working label Jul 31, 2023
@cdrani cdrani changed the title [Bug] Playlist Tracklists Do Not Show Skip & Settings Icons [Bug]: Playlist TrackLists Do Not Show Skip & Settings Icons Jul 31, 2023
@cdrani cdrani added help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed good first issue Good for newcomers labels Jul 31, 2023
@cdrani cdrani closed this as completed in #39 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

1 participant