Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Update #chorus-controls Style Properties #98

Closed
cdrani opened this issue Sep 3, 2023 · 1 comment · Fixed by #102
Closed

[BUG]: Update #chorus-controls Style Properties #98

cdrani opened this issue Sep 3, 2023 · 1 comment · Fixed by #102
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cdrani
Copy link
Owner

cdrani commented Sep 3, 2023

Describe the bug

Currently using a dashed border around the chorus controls modal. Time for a change perhaps?
image

Expected behavior

Possible New border styles. These are starting points, but use your eyes to feel it out and make it look good.

  1. maybe a 6px border radius, 3px width, ridge
  2. maybe a solid border, 3px width, optional border-radius of 6, 8, or 10 px
  3. Open to other possibilities, but would prefer not to use dashed or dotted

Additional context

Location of #chorus-controls styles. Combine the two blocks into a single #chorus-controls block.

chorus/src/styles.css

Lines 46 to 57 in 4e8e7d5

#chorus-controls {
border: 1px dashed #1ed760;
}
#chorus-controls {
position: fixed;
left: 80px;
bottom: 80px;
padding: .5rem .75rem;
background-color: #171717;
width: 320px;
}

@cdrani cdrani added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 3, 2023
@ahmohil
Copy link
Contributor

ahmohil commented Sep 3, 2023

I want to work on this kindly assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

2 participants