Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate bulk sms limit #294

Merged
merged 8 commits into from May 21, 2024
Merged

Reinstate bulk sms limit #294

merged 8 commits into from May 21, 2024

Conversation

whabanks
Copy link
Contributor

@whabanks whabanks commented May 3, 2024

Summary | Résumé

This PR reinstates bulk sms validation code that was reverted in this PR as well as this one due to issues with the added validation firing on bulk emails as well.

Related Issues | Cartes liées

cds-snc/notification-api#2169
cds-snc/notification-admin#1834

Test instructions | Instructions pour tester la modification

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you be bumping the utils version with this PR?

@whabanks
Copy link
Contributor Author

Should you be bumping the utils version with this PR?

Yep! 52.2.0 was the tag for the revert. We need to merge this one and re-tag before we merge:
cds-snc/notification-api#2169
cds-snc/notification-admin#1834

@whabanks whabanks requested a review from jzbahrai May 14, 2024 13:56
@whabanks whabanks merged commit 1e2c279 into main May 21, 2024
4 checks passed
@whabanks whabanks deleted the reinstate-bulk-sms-limit branch May 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants