Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: Audience was not checked in versions < 0.14.0 (2024-01-22) #46

Closed
lcmgh opened this issue Feb 21, 2024 · 2 comments
Closed

Comments

@lcmgh
Copy link

lcmgh commented Feb 21, 2024

On 0.14 token validation fails with an InvalidAudience error when .validation(Validation::new().aud(&[config.audience])) is not set. Prior 0.14 one had to validate audience on its own and skipping .validation was not a problem.

Would have been helpful if this breaking change were mentioned in the CHANGELOG.

@lcmgh lcmgh changed the title Audience was not checked in versions < 0.14.0 (2024-01-22) Doc: Audience was not checked in versions < 0.14.0 (2024-01-22) Feb 21, 2024
@lcmgh lcmgh changed the title Doc: Audience was not checked in versions < 0.14.0 (2024-01-22) Changelog: Audience was not checked in versions < 0.14.0 (2024-01-22) Feb 21, 2024
@Bromles
Copy link

Bromles commented Apr 15, 2024

This was a very unpleasant surprise during the update, especially considering that the error occurs only in runtime.

For my specific use case, I cannot check the audience when validating the token. And, interestingly, the jsonwebtoken crate that this library uses allows to disable this check. But here the validation options do not provide such an opportunity. I really don't want to fork just to add 1 new validation option, but if it doesn't get fixed I'll have to do this

@Bromles
Copy link

Bromles commented Apr 15, 2024

Made a quick PR to fix this

#48

@lcmgh lcmgh closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants