Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing compose simplifications #1381

Open
nofiv opened this issue Aug 31, 2021 · 4 comments
Open

Missing compose simplifications #1381

nofiv opened this issue Aug 31, 2021 · 4 comments

Comments

@nofiv
Copy link
Contributor

nofiv commented Aug 31, 2021

Hello, I believe that expressions like ({0x46 0 8, expr_id 8 32} & 0x40)?(0x20, 0x30) could be further simplified, however expr_simp() doesn't seem to contain such pass. Am I missing something please?

@serpilliere
Copy link
Contributor

Hi @nofiv
You are right: we may add a simplification here.
Moreover this simplification seems quite "generic" so it's interesting to add it to the engine.
Do you want to try to do a PR or do you prefer I add it ?

@nofiv
Copy link
Contributor Author

nofiv commented Sep 4, 2021

Hello @serpilliere , I will try to do the PR

@serpilliere
Copy link
Contributor

In fact it seems I have missing #1347
I totally missed it from the submitted PR.

It seams that it's exactly what you requested right?

@nofiv
Copy link
Contributor Author

nofiv commented Sep 6, 2021

Oh, great. Yes, that's exactly what I wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants