Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Installation with pip fails if kombu is not installed #4

Closed
carletes opened this issue Nov 12, 2013 · 4 comments
Closed

Installation with pip fails if kombu is not installed #4

carletes opened this issue Nov 12, 2013 · 4 comments
Milestone

Comments

@carletes
Copy link
Contributor

If I try to do a

$ pip install callme

in a fresh virtualenv (with no kombu installed), pip cannot do its job:

Downloading/unpacking callme (from -r requirements.txt (line 5))
  Running setup.py egg_info for package callme
Traceback (most recent call last):
  File "<string>", line 16, in <module>
  File "/home/systems/syv/.virtualenvs/webdev/build/callme/setup.py", line 13, in <module>
        import callme
  File "src/callme/__init__.py", line 10, in <module>
        from server import Server
  File "src/callme/server.py", line 8, in <module>
        from kombu import BrokerConnection, Exchange, Queue, Consumer, Producer
ImportError: No module named kombu

Although the dependency on kombu is explicit in setup.py, that file (setup.py) also has the following statement:

import callme

(on line 13 as of callme 0.1.0) which fails if kombu is not already present.

I suggest moving the symbols __version__, __author__ and similar from module callme to something like callme.info, for instance, and then doing:

from callme import info

from setup.py.

@ceelian
Copy link
Owner

ceelian commented Dec 20, 2013

PR merged, thx.

@ceelian ceelian closed this as completed Dec 20, 2013
@carletes
Copy link
Contributor Author

carletes commented Jan 9, 2014

Thanks, @ceelian! Any plans to upload version 0.1.1 to PyPI?

Carlos

@ceelian
Copy link
Owner

ceelian commented Jan 9, 2014

I want to get the some more PR merged unless I get it to PyPi. But 0.1.2 which should be released soon will be uploaded to PyPi.

@carletes
Copy link
Contributor Author

carletes commented Jan 9, 2014

Thanks, @ceelian!

@ceelian ceelian added this to the v0.2 milestone Jul 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants