Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of the mapping template jar file #12

Closed
AuPath opened this issue Apr 2, 2024 · 1 comment
Closed

Name of the mapping template jar file #12

AuPath opened this issue Apr 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@AuPath
Copy link
Collaborator

AuPath commented Apr 2, 2024

Currently, the mapping-template JAR file follows the 'mapping-template-x.y.z' naming convention. This means that whenever a new version of the mapping-template is released, existing scripts integrating it require modification, even if there are no functional changes. Similarly, building the mapping-template via a Dockerfile (#9) presents challenges, as the resulting JAR file must be referenced by its version, necessitating Dockerfile updates for each release.

To simplify, I propose renaming it to 'mapping-template.jar' or 'mapt.jar' to ease command line usage. The version of the mapping-template.jar file should instead be exposed by a --version flag. @marioscrock, what do you think?

@AuPath AuPath added the enhancement New feature or request label Apr 2, 2024
@AuPath AuPath self-assigned this Apr 2, 2024
@marioscrock
Copy link
Member

I agree with adding a --version flag, but I think it is preferable to force the user to rename the JAR instead of making it versionless (see also link).

Regarding the Dockerfile, we can use a "wildcard" when referencing the JAR (e.g., see link).

@AuPath AuPath closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants