Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SYCL 2020 CTAD accessors #24

Closed
psalz opened this issue May 7, 2021 · 0 comments · Fixed by #33
Closed

Add support for SYCL 2020 CTAD accessors #24

psalz opened this issue May 7, 2021 · 0 comments · Fixed by #33
Assignees
Milestone

Comments

@psalz
Copy link
Member

psalz commented May 7, 2021

SYCL 2020 raised the required language level to C++17, and with that, several improvements to the existing interfaces could be made. One of the major usability improvements is to make it easier to create buffer accessors. Going from this:

auto acc = my_buffer.get_access<sycl::access::mode::read_write>(cgh);

To this:

sycl::accessor acc { my_buffer, cgh, sycl::read_write };

The most notable part of this change is the use of deduction tags such as sycl::read_write to infer the access mode using C++17 CTAD.

We should align our interfaces to match this, where possible. I'm creating this issue mostly for documentation purposes, as @facuMH is already looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants