Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Load task modules from all registered Django app configs” #6738

Closed
aruseni opened this issue Apr 23, 2021 · 3 comments
Closed

“Load task modules from all registered Django app configs” #6738

aruseni opened this issue Apr 23, 2021 · 3 comments

Comments

@aruseni
Copy link
Contributor

aruseni commented Apr 23, 2021

Hey, I think this phrase should be changed.

https://docs.celeryproject.org/en/stable/django/first-steps-with-django.html

# Load task modules from all registered Django app configs.
app.autodiscover_tasks()

We actually load the “tasks” modules from the apps themselves.

In other words, app configs do not have “tasks” modules, apps do.

So it would probably be better to say precisely that:

Load task modules from all registered Django apps.

@open-collective-bot
Copy link

Hey @aruseni 👋,
Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors.
If you require immediate assistance please consider sponsoring us.

@auvipy
Copy link
Member

auvipy commented Apr 24, 2021

let's change it. need not to open issue for this type of tiny changes in docs

@aruseni
Copy link
Contributor Author

aruseni commented Apr 24, 2021

Sure. Just wanted any of you guys to confirm. Thanks.

@aruseni aruseni closed this as completed Apr 24, 2021
aruseni added a commit to aruseni/celery that referenced this issue Apr 24, 2021
See celery#6738 for an explanation why it’s better to say “registered apps”.
auvipy pushed a commit that referenced this issue Apr 25, 2021
See #6738 for an explanation why it’s better to say “registered apps”.
jeyrce pushed a commit to jeyrce/celery that referenced this issue Aug 25, 2021
See celery#6738 for an explanation why it’s better to say “registered apps”.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants