Upgrade AzureBlockBlob storage backend to use Azure blob storage library v12 #6580
Conversation
|
This pull request fixes 2 alerts when merging a271577 into 2dd6769 - view on LGTM.com fixed alerts:
|
|
could you please check if there are any other things that need to be updated? integration test/tox etc? |
|
This pull request introduces 17 alerts and fixes 3 when merging 0493f66 into 2c6f46d - view on LGTM.com new alerts:
fixed alerts:
|
|
Hi, Both unit & integration tests related to the AzureBlockBlob storage backend are passing when using the environment set up with Docker and docker-compose. However, I had to change the azurite docker image used when spinning up the environment (It is now using the official Microsoft image). I've committed this change to the remote branch. Regarding tox: I do not believe anything should be changed. |
There was a problem hiding this comment.
can you check the following alerts?
This pull request introduces 17 alerts and fixes 3 when merging 0493f66 into 2c6f46d - view on LGTM.com
new alerts:
12 for Wrong number of arguments in a call
3 for Module is imported with 'import' and 'import from'
1 for __eq__ not overridden when adding attributes
1 for Use of the return value of a procedure
|
@auvipy do you have still objections? |
…ary v12 (celery#6580) * Upgrade AzureBlockBlob backend to use library azure-storage-blob v12 * Fix minor bug in AzureBlockBlob backend unit test * Upgrade AzureBlockBlob backend to use library azure-storage-blob v12 * Fix minor bug in AzureBlockBlob backend unit test * Bug fixes in AzureBlockBlob class and unit tests * Update docker-compose.yml to use Microsoft's official azurite docker image Co-authored-by: Janus Asmussen <jjasmussen@outlook.com>
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
This PR upgrades the AzureBlockBlob storage backend to use Azure blob storage library v12. This replaces the currently used SDK (Azure blob storage library v2.1) which is considered a legacy version by Microsoft.