Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass_context for handle_preload_options decorator #6583

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

jor-rit
Copy link

@jor-rit jor-rit commented Jan 8, 2021

handle_reload_options requires the ctx argument.

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Several sub-commands throw an error:
TypeError: caller() missing 1 required positional argument: 'ctx'

Seems to be caused by a change in #6516
The @handle_preload_options decorator requires ctx argument, so they need @click.pass_context

Fixes #6582

handle_reload_options requires the ctx argument.
@lgtm-com
Copy link

lgtm-com bot commented Jan 8, 2021

This pull request fixes 1 alert when merging 23e0547 into 2c6f46d - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause

@auvipy auvipy added this to the 5.0.6 milestone Jan 9, 2021
@auvipy auvipy requested a review from thedrow January 9, 2021 14:49
@thedrow
Copy link
Member

thedrow commented Jan 10, 2021

FYI The build is still a work in progress.

@thedrow thedrow merged commit 8ff578f into celery:master Jan 10, 2021
@auvipy
Copy link
Member

auvipy commented Jan 10, 2021

I will put another PR on build front tomorrow. doing analysis.

@jor-rit jor-rit deleted the cli_ctx_fix branch January 11, 2021 08:27
@thedrow thedrow modified the milestones: 5.0.6, 5.1.0 Feb 24, 2021
@thedrow thedrow added this to Done in Celery 5.1.0 Feb 24, 2021
thedrow pushed a commit that referenced this pull request May 24, 2021
handle_reload_options requires the ctx argument.
jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
handle_reload_options requires the ctx argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Celery 5.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

cli (sub)commands missing 'ctx' error
3 participants