Add new setting: 'task_args_repr_function'.

[arnau126]

Description

Add new setting: task_args_repr_function (perhaps there is a more appropriate name).
This setting allows you to choose which function do you want to use to generate argsrepr and kwargsrepr (the string representation of the task args and kwargs used for logging purposes).

Default is "celery.utils.saferepr.saferepr" which is the currently used function.

Examples

def task_args_repr_function(o, **kwargs):
    return json.dumps(o)

so it will be easier to parse them later on in some backends like the one of django-celery-results.

or

def task_args_repr_function(o, **kwargs):
    if isinstance(o, dict):
        o = o.copy()
        if 'card_number' in o:
            o['card_number'] = '***'
        if 'phone_number' in o:
            o['phone_number'] = o['phone_number'][:3]
        if 'email' in o:
            o.pop('email')
    return repr(o)

so we don't have to specify kwargsrepr param at each task call.

Tests

Tests not done yet. Please let me know if you agree with this approach, and I will add some tests.

[auvipy]

it will tke sometime to review & reach a consensus. I will start tomorrow

[thedrow]

I have a few comments.
This requires tests to be merged, as well.

[thedrow]

In my opinion, this fallback is inappropriate for most if not all cases.
We should raise an ImproperlyConfigured exception instead if that is the case.

[arnau126]

With task_protocol=1, the backend receives the original args and kwargs values (i.e. as tuple and dict)
With this fallback I was trying to get the same.
Anyway, I will just raise ImproperlyConfigured as you suggest.
Explicit is better than implicit.

[thedrow]

We should test if repr_function is a callable.
If it isn't this should also raise an ImproperlyConfigured exception.

[thedrow]

Suggested change

	.. versionadded: 5.?
	.. versionadded: 5.1

[thedrow]

@arnau126 This is a friendly ping to remind you to complete this pull request.

[xirdneh]

@arnau126 If you don't have time to finish this PR I can take over.

[arnau126]

@thedrow, sorry I'm very busy these days.
@xirdneh I'd be very grateful if you take over the PR. Thanks!

[auvipy]

@thedrow, sorry I'm very busy these days. @xirdneh I'd be very grateful if you take over the PR. Thanks!

what remains to draw the finishing line?

[auvipy]

@thedrow, sorry I'm very busy these days. @xirdneh I'd be very grateful if you take over the PR. Thanks!

can you return to this now?

[xirdneh]

@auvipy Hey, sure thing I can take over.

[auvipy]

ok great

[saichander17]

Hi all,
Just checking to see if someone is working on this PR and any estimate on when this would be released.
@xirdneh

[auvipy]

no one is working. you can take over

[berryscone]

any further progress on it?

[auvipy]

no we need new contributors to take this over