-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exit celery with non zero exit value if failing #6602
Conversation
This pull request fixes 2 alerts when merging 2f5758f into 855d551 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a specialized exception.
We can simply use ctx.fail()
.
If I look at please advice on direction to solve this issue |
Huh. I think we're good to go on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. should we merge this as is or need unit test?
There are no unit tests for the CLI at the time being, unfortunately. |
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
There is an issue with version 5.x for the celery command. If the command is failing, the exit value is still 0. This PR will fix this and exits with the intended exit value.
NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.
If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #6601) for example.
-->