Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor in exception handling of on_failure #6633

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

pakallis
Copy link
Contributor

Description

  • Use the previously declared variable exc to avoid duplication in if statements

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 2 alerts when merging ea5bc31 into 948bb79 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Module is imported with 'import' and 'import from'

@thedrow thedrow added this to the 5.1.0 milestone Feb 14, 2021
@thedrow thedrow merged commit a5357ca into celery:master Feb 14, 2021
@auvipy auvipy linked an issue Feb 16, 2021 that may be closed by this pull request
18 tasks
@auvipy auvipy removed a link to an issue Feb 16, 2021
18 tasks
@thedrow thedrow added this to Done in Celery 5.1.0 Feb 24, 2021
jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
Co-authored-by: Pavlos Kallis <p.kallis@centaur.ag>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Celery 5.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants