Allow configuration of RedisBackend's health_check_interval #6666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6666 +/- ##
==========================================
- Coverage 75.60% 70.46% -5.14%
==========================================
Files 138 138
Lines 16377 16497 +120
Branches 2052 2074 +22
==========================================
- Hits 12382 11625 -757
- Misses 3777 4669 +892
+ Partials 218 203 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
auvipy
requested changes
Mar 9, 2021
|
This pull request introduces 1 alert when merging 6c7148b into f091bab - view on LGTM.com new alerts:
|
auvipy
reviewed
Mar 10, 2021
auvipy
approved these changes
Mar 16, 2021
|
thanks, both of you! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
馃憢 Hey folks,
Was working through a reliability issue on our end with our Redis connections and came across the need to update the
health_check_intervalfor the underlying Redis connection. The goal here is a simple implementation that allows reading this value via environment variable (redis_backend_health_check_interval) and passing this through as akwargto the underlyingredis-pymodule.This is my proposed solution to #6665. Please let me know what you think and thank you for the great library.
Cheers,
Chris