Fix checking expiration of X.509 certificates #6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`not_valid_after` is a naïve datetime representing a moment in UTC. It should not be compared to a naïve datetime representing the current local date and time. Also, the value is inclusive. https://cryptography.io/en/3.4.6/x509/reference.html#cryptography.x509.Certificate.not_valid_after
Codecov Report
@@ Coverage Diff @@
## master #6678 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 138 138
Lines 16494 16494
Branches 2073 2073
=======================================
Hits 11624 11624
Misses 4668 4668
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
auvipy
approved these changes
Mar 14, 2021
|
This pull request introduces 1 alert and fixes 1 when merging 5966c86 into 4d77ddd - view on LGTM.com new alerts:
fixed alerts:
|
thedrow
approved these changes
Mar 15, 2021
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
`not_valid_after` is a naïve datetime representing a moment in UTC. It should not be compared to a naïve datetime representing the current local date and time. Also, the value is inclusive. https://cryptography.io/en/3.4.6/x509/reference.html#cryptography.x509.Certificate.not_valid_after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
not_valid_afteris a naïve datetime representing a moment in UTC. It should not be compared to a naïve datetime representing the current local date and time.Also, the value is inclusive.
https://cryptography.io/en/3.4.6/x509/reference.html#cryptography.x509.Certificate.not_valid_after