Tasks can now have required kwargs at any order #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5469. Thanks to @dimavitvickiy for the initial research in #5485.
Codecov Report
@@ Coverage Diff @@
## master #6699 +/- ##
==========================================
- Coverage 70.46% 70.46% -0.01%
==========================================
Files 138 138
Lines 16505 16504 -1
Branches 2076 2076
==========================================
- Hits 11630 11629 -1
Misses 4670 4670
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert and fixes 2 when merging dec49f6 into a78f8cc - view on LGTM.com new alerts:
fixed alerts:
|
auvipy
approved these changes
Mar 30, 2021
|
pypy failure is not related, right? |
Yes it isn't. |
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
Fixes celery#5469. Thanks to @dimavitvickiy for the initial research in celery#5485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes #5469.
Thanks to @dimavitvickiy for the initial research in #5485.