Fix UnboundLocalError when running celery worker in foreground #6833

michael-k · 2021-06-30T15:26:52Z

Description

Add the indentation missed in commit 56a6246. The bug is not present in branch master.

Fixes #6830

lgtm-com · 2021-06-30T15:59:07Z

This pull request introduces 1 alert and fixes 1 when merging 7b1647d into 171ab02 - view on LGTM.com

new alerts:

1 for Non-exception in 'except' clause

fixed alerts:

1 for Unreachable code

maybe-sybr

Whoops, looks like a conflict resolution mistake when backporting 6e5580 onto the 5.0 release branch (as 56a6246). Those two commits should be pretty much identical but the merge from master into #6599 probably confused things.

lgtm! Thanks for the PR @michael-k. Leaving for @thedrow to merge due to the pending review or I'll aim to come back and hit the button myself later today.

maybe-sybr · 2021-07-01T23:11:19Z

Interesting that I can't seem to start the unit test checks on this PR... I assumed it was because @michael-k might be a first time contributor but that's not the case :/ Perhaps we need to amend to workflow rules to match our stable/release branch names as well?

auvipy · 2021-07-02T05:30:35Z

Interesting that I can't seem to start the unit test checks on this PR... I assumed it was because @michael-k might be a first time contributor but that's not the case :/ Perhaps we need to amend to workflow rules to match our stable/release branch names as well?

yup

thedrow · 2021-07-21T10:30:29Z

I have updated the workflow.
@michael-k Would you mind rebasing, please?

michael-k · 2021-07-21T10:46:49Z

Would you mind rebasing, please?

There are no new commits in branch 5.0 🤷

Edit: I've recreated the commit to trigger a new workflow run.

auvipy

needs another rebase

michael-k · 2021-07-21T11:28:08Z

needs another rebase

Rebase onto what? Before I can rebase, you need to push something to branch 5.0. The changes that pre-commit requests are unrelated to this PR and should be done in 5.0 first.

lgtm-com · 2021-07-21T11:29:23Z

This pull request fixes 3 alerts when merging 3927a84 into 171ab02 - view on LGTM.com

fixed alerts:

1 for Non-exception in 'except' clause
1 for Unreachable code
1 for Module is imported with 'import' and 'import from'

thedrow · 2021-07-21T12:41:57Z

Would you mind rebasing, please?

There are no new commits in branch 5.0 🤷

Edit: I've recreated the commit to trigger a new workflow run.

Yes I should have cherry-picked it myself.🤦 Sorry.

thedrow · 2021-07-21T13:42:09Z

CI will run now in this branch.

thedrow · 2021-07-21T13:50:24Z

The CI still isn't running so this needs more work. I'll keep you posted.

Fixes celery#6830

codecov · 2021-07-21T14:35:43Z

Codecov Report

Merging #6833 (fb6b8a6) into 5.0 (b221d69) will decrease coverage by 0.01%.
The diff coverage is 69.31%.

@@            Coverage Diff             @@
##              5.0    #6833      +/-   ##
==========================================
- Coverage   75.42%   75.41%   -0.02%     
==========================================
  Files         138      138              
  Lines       16418    16422       +4     
  Branches     2050     2050              
==========================================
+ Hits        12384    12385       +1     
- Misses       3818     3821       +3     
  Partials      216      216

Flag	Coverage Δ
unittests	`75.41% <69.31%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
celery/__main__.py	`0.00% <0.00%> (ø)`
celery/bin/amqp.py	`0.00% <0.00%> (ø)`
celery/bin/base.py	`0.00% <0.00%> (ø)`
celery/bin/beat.py	`0.00% <0.00%> (ø)`
celery/bin/call.py	`0.00% <0.00%> (ø)`
celery/bin/celery.py	`0.00% <0.00%> (ø)`
celery/bin/control.py	`0.00% <0.00%> (ø)`
celery/bin/events.py	`0.00% <0.00%> (ø)`
celery/bin/list.py	`0.00% <0.00%> (ø)`
celery/bin/migrate.py	`0.00% <0.00%> (ø)`
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b221d69...fb6b8a6. Read the comment docs.

lgtm-com · 2021-07-21T14:54:48Z

This pull request fixes 1 alert when merging cd61c10 into b221d69 - view on LGTM.com

fixed alerts:

1 for Unreachable code

maybe-sybr · 2021-07-21T23:43:39Z

Looks like the CI failures are unrelated to this diff. Also the pre-commit job put a huge, nasty style commit on the end of this PR which should be sorted out on 5.0 (or master and cherry picked back) rather than here.

py10 failure

  _________________ ERROR collecting t/unit/backends/test_s3.py __________________
  t/unit/backends/test_s3.py:6: in <module>
      from moto import mock_s3
  .tox/3.10-unit/lib/python3.10/site-packages/moto/__init__.py:12: in <module>
      from .cloudformation import mock_cloudformation, mock_cloudformation_deprecated  # flake8: noqa
  .tox/3.10-unit/lib/python3.10/site-packages/moto/cloudformation/__init__.py:2: in <module>
      from .models import cloudformation_backends
  .tox/3.10-unit/lib/python3.10/site-packages/moto/cloudformation/models.py:11: in <module>
      from .parsing import ResourceMap, OutputMap
  .tox/3.10-unit/lib/python3.10/site-packages/moto/cloudformation/parsing.py:366: in <module>
      class ResourceMap(collections.Mapping):
  E   AttributeError: module 'collections' has no attribute 'Mapping'

Hmm, I think this should be collections.abc.Mapping. Is this broken on master also?

pypy3 failure

     Running setup.py install for ephem: started
    Running setup.py install for ephem: finished with status 'error'

Seems like we need 6c8c93c, which was part of the #6635 diff to get CI working of pypy3. The squashed merge commit is 117cd9c and should probably be cherry picked onto the 5.0 branch and then have this rebased on top.

lint failure

  An unexpected error has occurred: CalledProcessError: command: ('/home/runner/work/celery/celery/.tox/lint/bin/python', '-mvirtualenv', '/home/runner/.cache/pre-commit/repo_sawvi81/py_env-python3.7', '-p', 'python3.7')
  return code: 1
  expected return code: 0
  stdout:
      RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.7'

lint failure

It's trying to run under python3.7 which isn't available in the job environment. Surprising, I thought the lint job was supposed to run using tox in a python3.9 environment.

for more information, see https://pre-commit.ci

lgtm-com · 2021-07-22T08:41:42Z

This pull request introduces 1 alert and fixes 1 when merging fb6b8a6 into b221d69 - view on LGTM.com

new alerts:

1 for Module is imported with 'import' and 'import from'

fixed alerts:

1 for Unreachable code

thedrow · 2021-07-22T09:23:43Z

@maybe-sybr Thanks for helping me with the investigation. ❤️

thedrow self-requested a review June 30, 2021 15:41

maybe-sybr approved these changes Jul 1, 2021

View reviewed changes

auvipy approved these changes Jul 2, 2021

View reviewed changes

thedrow added PR Type: Bugfix Version: 5.0 labels Jul 21, 2021

thedrow self-assigned this Jul 21, 2021

thedrow approved these changes Jul 21, 2021

View reviewed changes

michael-k force-pushed the fix-6830 branch from 7b1647d to 1b0f0f5 Compare July 21, 2021 10:56

auvipy requested changes Jul 21, 2021

View reviewed changes

thedrow force-pushed the fix-6830 branch from 3927a84 to 5eadd6a Compare July 21, 2021 13:41

thedrow force-pushed the fix-6830 branch from 5eadd6a to b74b5ec Compare July 21, 2021 13:52

Fix UnboundLocalError when running celery worker in foreground

c20cf16

Fixes celery#6830

thedrow force-pushed the fix-6830 branch from b74b5ec to cd61c10 Compare July 21, 2021 14:24

michael-k force-pushed the fix-6830 branch from cd61c10 to c20cf16 Compare July 22, 2021 08:15

[pre-commit.ci] auto fixes from pre-commit.com hooks

fb6b8a6

for more information, see https://pre-commit.ci

thedrow added this to the 5.1.x milestone Aug 17, 2021

thedrow merged commit 2b7c83d into celery:5.0 Aug 17, 2021

thedrow linked an issue Aug 17, 2021 that may be closed by this pull request

UnboundLocalError when running celery worker in foreground #6830

Closed

18 tasks

michael-k deleted the fix-6830 branch November 22, 2021 14:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix UnboundLocalError when running celery worker in foreground #6833

Fix UnboundLocalError when running celery worker in foreground #6833

michael-k commented Jun 30, 2021 •

edited

lgtm-com bot commented Jun 30, 2021

maybe-sybr left a comment •

edited

maybe-sybr commented Jul 1, 2021 •

edited

auvipy commented Jul 2, 2021

thedrow commented Jul 21, 2021

michael-k commented Jul 21, 2021 •

edited

auvipy left a comment

michael-k commented Jul 21, 2021

lgtm-com bot commented Jul 21, 2021

thedrow commented Jul 21, 2021

thedrow commented Jul 21, 2021

thedrow commented Jul 21, 2021

codecov bot commented Jul 21, 2021 •

edited

lgtm-com bot commented Jul 21, 2021

maybe-sybr commented Jul 21, 2021 •

edited

lgtm-com bot commented Jul 22, 2021

thedrow commented Jul 22, 2021

Fix UnboundLocalError when running celery worker in foreground #6833

Fix UnboundLocalError when running celery worker in foreground #6833

Conversation

michael-k commented Jun 30, 2021 • edited

Description

lgtm-com bot commented Jun 30, 2021

maybe-sybr left a comment • edited

Choose a reason for hiding this comment

maybe-sybr commented Jul 1, 2021 • edited

auvipy commented Jul 2, 2021

thedrow commented Jul 21, 2021

michael-k commented Jul 21, 2021 • edited

auvipy left a comment

Choose a reason for hiding this comment

michael-k commented Jul 21, 2021

lgtm-com bot commented Jul 21, 2021

thedrow commented Jul 21, 2021

thedrow commented Jul 21, 2021

thedrow commented Jul 21, 2021

codecov bot commented Jul 21, 2021 • edited

Codecov Report

lgtm-com bot commented Jul 21, 2021

maybe-sybr commented Jul 21, 2021 • edited

py10 failure

pypy3 failure

lint failure

lint failure

lgtm-com bot commented Jul 22, 2021

thedrow commented Jul 22, 2021

michael-k commented Jun 30, 2021 •

edited

maybe-sybr left a comment •

edited

maybe-sybr commented Jul 1, 2021 •

edited

michael-k commented Jul 21, 2021 •

edited

codecov bot commented Jul 21, 2021 •

edited

maybe-sybr commented Jul 21, 2021 •

edited