Fix #6844 by allowing safe queries via app.inspect().active(). #6849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries via app.inspect().active().
|
This pull request introduces 2 alerts when merging f2d2f90 into e885a47 - view on LGTM.com new alerts:
|
auvipy
requested changes
Jul 9, 2021
|
tests are still failing |
…ng when safe=True).
Codecov Report
@@ Coverage Diff @@
## master #6849 +/- ##
=======================================
Coverage 79.20% 79.21%
=======================================
Files 138 138
Lines 16612 16616 +4
Branches 2097 2097
=======================================
+ Hits 13158 13162 +4
Misses 3227 3227
Partials 227 227
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
auvipy
approved these changes
Jul 9, 2021
|
thanks! |
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
…elery#6849) * Fix celery#6844 by allowing safe (i.e. skip arg derserialization) queries via app.inspect().active(). * Fix default active arg test expectation. * Fix test asserting broken behaviour (arg/kwarg deserialization occuring when safe=True). Co-authored-by: Damir Jungic <djungic@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Restores the
safeoption toapp.control.inspect.active. This affords querying active tasks from context that might not be able to deserialize task arguments. See #6844 for details and when the breakage occurred.