-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6844 by allowing safe queries via app.inspect().active(). #6849
Conversation
…ries via app.inspect().active().
This pull request introduces 2 alerts when merging f2d2f90 into e885a47 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the build failures
tests are still failing |
…ng when safe=True).
Codecov Report
@@ Coverage Diff @@
## master #6849 +/- ##
=======================================
Coverage 79.20% 79.21%
=======================================
Files 138 138
Lines 16612 16616 +4
Branches 2097 2097
=======================================
+ Hits 13158 13162 +4
Misses 3227 3227
Partials 227 227
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thanks! |
…elery#6849) * Fix celery#6844 by allowing safe (i.e. skip arg derserialization) queries via app.inspect().active(). * Fix default active arg test expectation. * Fix test asserting broken behaviour (arg/kwarg deserialization occuring when safe=True). Co-authored-by: Damir Jungic <djungic@cisco.com>
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Restores the
safe
option toapp.control.inspect.active
. This affords querying active tasks from context that might not be able to deserialize task arguments. See #6844 for details and when the breakage occurred.