-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route chord_unlock task to the same queue as chord body #6896
Route chord_unlock task to the same queue as chord body #6896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just the fix I had in mind so well done!
Could you please include a unit test in this patch to verify that this works as expected?
The relevant test fails as the expected outcome has changed. |
Glad to hear that! That was the intention of creating issue and PR -- get feedback whether I am on the right path.
I guess I fixed existing tests. But I think new test should be also added. I will try to work on this on the weekend. Thanks for the feedback! |
This pull request introduces 2 alerts when merging 4d317f1 into 846066a - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #6896 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 138 138
Lines 16626 16628 +2
Branches 2099 2100 +1
=======================================
+ Hits 14836 14838 +2
Misses 1571 1571
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thanks! |
* Route chord_unlock task to the same queue as chord body * fix existing tests * add case to cover bugfix
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes #6888