Prevent worker to send expired revoked items upon hello command #6975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging dcb99db into 71ed45d - view on LGTM.com new alerts:
|
|
Alerts are not caused by my PR. They are already in |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #6975 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 138 138
Lines 16729 16730 +1
Branches 2120 2120
=======================================
+ Hits 14931 14932 +1
Misses 1575 1575
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request introduces 2 alerts when merging e0228d4 into 71ed45d - view on LGTM.com new alerts:
|
auvipy
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue when a newly spawned worker receives a lot of old and expired revocations.
There is no reason to send old revocations that are already expired.
In bigger systems that rely on revocations and use a much larger
LimitedSetthis is a problem as the hello response may be hundreds of megabytes large. Receiving such a large message from other workers takes a lot of time and also stresses RabbitMQ (the broker we use). This is also a way to reclaim some memory back in case there are no longer active revocations.Let me know what do you think about it.