New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing to Celery #7325
Add typing to Celery #7325
Conversation
This is a simple bootstrap of the process, adding some types to a few selected functions, based on comment annotations. MyPy is chosen as the default static analyzer for the types.
Codecov Report
@@ Coverage Diff @@
## master #7325 +/- ##
==========================================
- Coverage 89.33% 89.32% -0.02%
==========================================
Files 138 138
Lines 16781 16781
Branches 2451 2451
==========================================
- Hits 14991 14989 -2
- Misses 1559 1561 +2
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This pull request introduces 1 alert and fixes 2 when merging edd9dc4 into 095cd78 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking this stub, can you check the lint failures please?
Yes. I'm working on it. Have some patience ;) |
Is the idea here to incrementally increase typing on Celery? If yes, wouldn't it be interesting to support file by file? We did this on uvicorn: https://github.com/encode/uvicorn/blob/8585051189f0530165e901e0c5fab57998648943/setup.cfg#L5-L43 |
Do @atombrella you mind if I tackle the needed fixes here? |
Please do :) I'm currently a bit caught up on other things. |
I've created #7383 |
This is a simple bootstrap of the process, adding some types to a
few selected functions, based on comment annotations. MyPy is chosen as the
default static analyzer for the types.
It's an attempt to solve #7258 Note that the work is quite demanding.