Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expiration check #7552

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Fix expiration check #7552

merged 3 commits into from
Jun 7, 2022

Conversation

dobosevych
Copy link
Contributor

@dobosevych dobosevych commented Jun 6, 2022

Note: Before submitting this pull request, please review our contributing
guidelines
.

Migrated test from #7109.
expires can be only float or datetime, so the test wasn't completely valid. Datetime serialization fixed in kombu

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #7552 (55d700d) into master (9f891ee) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7552   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files         138      138           
  Lines       16799    16799           
  Branches     2458     2458           
=======================================
  Hits        15042    15042           
  Misses       1517     1517           
  Partials      240      240           
Flag Coverage Δ
unittests 89.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/app/base.py 96.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f891ee...55d700d. Read the comment docs.

@auvipy auvipy self-requested a review June 6, 2022 20:32
@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2022

This pull request introduces 1 alert and fixes 1 when merging 55d700d into 9f891ee - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@auvipy auvipy added this to the 5.3 milestone Jun 7, 2022
@auvipy auvipy merged commit 13bd136 into master Jun 7, 2022
@auvipy auvipy deleted the FixExpirationCheck branch June 7, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants