Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override integration test config using integration-tests-config.json #7778

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

thedrow
Copy link
Member

@thedrow thedrow commented Sep 28, 2022

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

In order to allow to run the integration tests with a different configuration than the default, we now optionally allow to override the defaults using integration-tests-config.json.

@thedrow thedrow requested a review from Nusnus September 28, 2022 10:48
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 89.60% // Head: 89.60% // No change to project coverage 👍

Coverage data is based on head (f60dd6e) compared to base (6ea687b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7778   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         128      128           
  Lines       15860    15860           
  Branches     2346     2346           
=======================================
  Hits        14212    14212           
  Misses       1421     1421           
  Partials      227      227           
Flag Coverage Δ
unittests 89.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2022

This pull request introduces 1 alert when merging f60dd6e into 4f54119 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

@auvipy auvipy merged commit 7c1dcd0 into master Sep 28, 2022
@auvipy auvipy added this to the 5.3 milestone Sep 28, 2022
@Nusnus Nusnus deleted the blm-50 branch October 26, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants