Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the stamping visitor itself to set the stamp value type instead of casting it to a list #7914

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Nov 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Base: 89.89% // Head: 89.89% // No change to project coverage 👍

Coverage data is based on head (6c89591) compared to base (577eee6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7914   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         128      128           
  Lines       15896    15896           
  Branches     2140     2140           
=======================================
  Hits        14290    14290           
  Misses       1370     1370           
  Partials      236      236           
Flag Coverage Δ
unittests 89.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/app/amqp.py 94.78% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

… of casting it to a list even when the value is a single item
@auvipy
Copy link
Member

auvipy commented Nov 21, 2022

tests are passing

@Nusnus Nusnus marked this pull request as ready for review November 21, 2022 08:43
@Nusnus
Copy link
Member Author

Nusnus commented Nov 21, 2022

I forgot to click Ready for Review 😅

@Nusnus Nusnus requested a review from auvipy November 21, 2022 08:47
@Nusnus Nusnus added this to the 5.3 milestone Nov 21, 2022
@auvipy auvipy merged commit 1392936 into celery:master Nov 21, 2022
@Nusnus Nusnus deleted the blm-138 branch November 21, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants