Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamping a task left the task properties dirty #7916

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented Nov 21, 2022

No description provided.

@Nusnus Nusnus added this to the 5.3 milestone Nov 21, 2022
@Nusnus Nusnus self-assigned this Nov 21, 2022
@Nusnus Nusnus marked this pull request as ready for review November 21, 2022 15:50
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 89.89% // Head: 89.89% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4f25259) compared to base (1392936).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7916   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         128      128           
  Lines       15896    15899    +3     
  Branches     2140     2141    +1     
=======================================
+ Hits        14290    14293    +3     
  Misses       1370     1370           
  Partials      236      236           
Flag Coverage Δ
unittests 89.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/app/base.py 96.66% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nusnus Nusnus requested a review from auvipy November 21, 2022 19:47
@auvipy
Copy link
Member

auvipy commented Nov 22, 2022

also could you find additional issues like this?

@auvipy auvipy merged commit 570c4a6 into celery:master Nov 22, 2022
@Nusnus Nusnus deleted the blm-142 branch November 22, 2022 08:21
@Nusnus
Copy link
Member Author

Nusnus commented Nov 22, 2022

also could you find additional issues like this?

Sure!

And thanks for the review @auvipy ! 🤙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants